uranusjr commented on code in PR #51085:
URL: https://github.com/apache/airflow/pull/51085#discussion_r2108075056
##########
task-sdk/src/airflow/sdk/execution_time/task_runner.py:
##########
@@ -431,20 +431,19 @@ def get_ti_count(
"""Return the number of task instances matching the given criteria."""
log = structlog.get_logger(logger_name="task")
- with SUPERVISOR_COMMS.lock:
- SUPERVISOR_COMMS.send_request(
- log=log,
- msg=GetTICount(
- dag_id=dag_id,
- map_index=map_index,
- task_ids=task_ids,
- task_group_id=task_group_id,
- logical_dates=logical_dates,
- run_ids=run_ids,
- states=states,
- ),
- )
- response = SUPERVISOR_COMMS.get_message()
+ SUPERVISOR_COMMS.send_request(
+ log=log,
+ msg=GetTICount(
+ dag_id=dag_id,
+ map_index=map_index,
+ task_ids=task_ids,
+ task_group_id=task_group_id,
+ logical_dates=logical_dates,
+ run_ids=run_ids,
+ states=states,
+ ),
+ )
+ response = SUPERVISOR_COMMS.get_message()
Review Comment:
Are these changes correct? These are not async.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
