pierrejeambrun commented on code in PR #51115:
URL: https://github.com/apache/airflow/pull/51115#discussion_r2111458299
##########
airflow-core/src/airflow/api_fastapi/core_api/routes/ui/dags.py:
##########
@@ -95,71 +131,55 @@ def recent_dag_runs(
)
.label("rank"),
)
+ .where(DagRun.dag_id.in_([dag.dag_id for dag in dags]))
.order_by(DagRun.run_after.desc())
.subquery()
)
- dags_with_recent_dag_runs_select = (
+
+ recent_dag_runs_select = (
select(
- DagRun,
- DagModel,
recent_runs_subquery.c.run_after,
+ DagRun,
)
- .join(DagModel, DagModel.dag_id == recent_runs_subquery.c.dag_id)
.join(
DagRun,
and_(
- DagRun.dag_id == DagModel.dag_id,
+ DagRun.dag_id == recent_runs_subquery.c.dag_id,
DagRun.run_after == recent_runs_subquery.c.run_after,
),
)
.where(recent_runs_subquery.c.rank <= dag_runs_limit)
.group_by(
- DagModel.dag_id,
+ # DagModel.dag_id,
Review Comment:
Good catch, I forgot to remove it.
We don't need to because there's an inner join on recent_runs_subquery
(DagRun.dag_id == recent_runs_subquery.c.dag_id,) and that subquery is already
filtered on relevant dag ids.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
