choo121600 commented on PR #51735: URL: https://github.com/apache/airflow/pull/51735#issuecomment-2973612917
Finally reverted all unrelated files generated due to CI errors, and all CI checks are now green. 🎉 I'd like to share the issues I encountered during the process and how I resolved them: Initially, the translation files were under the `src` directory, so they passed the `typescriptRules` in `eslint.config.js` without any issues. However, after moving them to the `public` directory, the `typescriptRules` began to apply to them, which resulted in unnecessary file updates during CI runs. **To fix this:** - I moved the `i18nRules` above typescriptRules in the Lint config. - I added `public/i18n/locales/**/*.json` to the ignores. - I also installed `jsonc-eslint-parser` because i18nRules couldn't parse JSON files properly without it. Additionally, I updated DagCard.test.tsx to default to English and load translation files before running assertions. While modifying this file, I also cleaned up testsSetup.ts by removing manual matcher registration, which is no longer needed and was causing type conflicts. --- That said, since @jscheffl is also seeing the same issue. In particular, files inside openapi-gen/ are repeatedly being modified and throwing lint errors, even when no actual changes are made. This seems to be a side effect of the ESLint rules being too broadly applied to generated or static files. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
