ferruzzi commented on code in PR #51638:
URL: https://github.com/apache/airflow/pull/51638#discussion_r2150427968
##########
airflow-core/src/airflow/models/dag.py:
##########
@@ -1613,6 +1623,22 @@ def create_dagrun(
session=session,
)
+ if dag_deadline := self.get_dagrun_creation_deadlines():
+ Deadline.add_deadline(
Review Comment:
Yeah, I can see that I guess. It felt more "intuitive" this way and allowed
for future expansion if we decided we wanted logging or who knows what
later.... but maybe I was just overthinking/overengineering it.
How strongly do you feel about this, is it a blocking change or can we leave
it to see if anyone else wants to weigh in?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
