jscheffl commented on code in PR #52347: URL: https://github.com/apache/airflow/pull/52347#discussion_r2173858009
########## providers/slack/src/airflow/providers/slack/transfers/base_sql_to_slack.py: ########## @@ -21,7 +21,12 @@ from airflow.exceptions import AirflowException from airflow.hooks.base import BaseHook -from airflow.models import BaseOperator +from airflow.providers.slack.version_compat import AIRFLOW_V_3_0_PLUS + +if AIRFLOW_V_3_0_PLUS: + from airflow.sdk import BaseOperator +else: + from airflow.models import BaseOperator Review Comment: The idea was that the (redundant) selection of where to get BaseOperator from is moved to version_compat.py such that the few lines of boilerplate are in one place. Then you can import directly from there. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
