[
https://issues.apache.org/jira/browse/AIRFLOW-5819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16963225#comment-16963225
]
ASF GitHub Bot commented on AIRFLOW-5819:
-----------------------------------------
domantasjurkus commented on pull request #6473: [AIRFLOW-5819] Update
AWSBatchOperator default value
URL: https://github.com/apache/airflow/pull/6473
Make sure you have checked _all_ steps below.
### Jira
- [ ] My PR addresses the following [Airflow
Jira](https://issues.apache.org/jira/browse/AIRFLOW-5819) issues and references
them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
- https://issues.apache.org/jira/browse/AIRFLOW-XXX
- In case you are fixing a typo in the documentation you can prepend your
commit with \[AIRFLOW-XXX\], code changes always need a Jira issue.
- In case you are proposing a fundamental code change, you need to create
an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)).
- In case you are adding a dependency, check if the license complies with
the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
### Description
- [ ] Here are some details about my PR, including screenshots of any UI
changes:
The default value `None` throws an error, should be changed to `{}`.
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
I am actually not sure why the issue was not captured in the existing test:
https://github.com/apache/airflow/blob/73bf718358c01cc41e5f23b914a8824a2665a28c/tests/contrib/operators/test_awsbatch_operator.py#L39
### Commits
- [ ] My commits all reference Jira issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [ ] In case of new functionality, my PR adds documentation that describes
how to use it.
- All the public functions and the classes in the PR contain docstrings
that explain what it does
- If you implement backwards incompatible changes, please leave a note in
the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so
we can assign it to a appropriate release
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> AWSBatchOperator has invalid default value for array_properties
> ---------------------------------------------------------------
>
> Key: AIRFLOW-5819
> URL: https://issues.apache.org/jira/browse/AIRFLOW-5819
> Project: Apache Airflow
> Issue Type: Bug
> Components: operators
> Affects Versions: 1.10.6
> Reporter: Dom
> Priority: Major
>
> We upgraded our Airflow version from 1.10.3 to 1.10.6 and saw our
> AWSBatchOperator throwing the following error (easily fixed by changing the
> default param from None to {}):
> {code:java}
> [2019-10-30 13:10:15.392] INFO:airflow.task.operators.execute:93 Running AWS
> Batch Job - Job definition: batch-jobdef-1 - on queue AwsBatch-batch-queue
> [2019-10-30 13:10:15.393] INFO:airflow.task.operators.execute:95
> AWSBatchOperator overrides: {'command': ['--start_datetime', '2019-10-29']}
> [2019-10-30 13:10:15.433] INFO:airflow.task.operators.execute:121 AWS Batch
> Job has failed executed
> [2019-10-30 13:10:15.445] ERROR:airflow.task.handle_failure:1058 Parameter
> validation failed:
> Invalid type for parameter arrayProperties, value: None, type: <class
> 'NoneType'>, valid types: <class 'dict'>
> Traceback (most recent call last):
> File
> "/usr/local/lib/python3.7/site-packages/airflow/contrib/operators/awsbatch_operator.py",
> line 108, in execute
> containerOverrides=self.overrides)
> File "/usr/local/lib/python3.7/site-packages/botocore/client.py", line 357,
> in _api_call
> return self._make_api_call(operation_name, kwargs)
> File "/usr/local/lib/python3.7/site-packages/botocore/client.py", line 634,
> in _make_api_call
> api_params, operation_model, context=request_context)
> File "/usr/local/lib/python3.7/site-packages/botocore/client.py", line 682,
> in _convert_to_request_dict
> api_params, operation_model)
> File "/usr/local/lib/python3.7/site-packages/botocore/validate.py", line
> 297, in serialize_to_request
> raise ParamValidationError(report=report.generate_report())
> botocore.exceptions.ParamValidationError: Parameter validation failed:
> Invalid type for parameter arrayProperties, value: None, type: <class
> 'NoneType'>, valid types: <class 'dict'>During handling of the above
> exception, another exception occurred:Traceback (most recent call last):
> File
> "/usr/local/lib/python3.7/site-packages/airflow/models/taskinstance.py", line
> 930, in _run_raw_task
> result = task_copy.execute(context=context)
> File
> "/usr/local/lib/python3.7/site-packages/airflow/contrib/operators/awsbatch_operator.py",
> line 122, in execute
> raise AirflowException(e)
> airflow.exceptions.AirflowException: Parameter validation failed:
> Invalid type for parameter arrayProperties, value: None, type: <class
> 'NoneType'>, valid types: <class 'dict'>
> [2019-10-30 13:10:15.447] INFO:airflow.task.handle_failure:1087 All retries
> failed; marking task as FAILED{code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
