yeswanth-bf commented on code in PR #52431:
URL: https://github.com/apache/airflow/pull/52431#discussion_r2178974491
##########
providers/standard/src/airflow/providers/standard/sensors/external_task.py:
##########
@@ -534,7 +534,9 @@ def _handle_execution_date_fn(self, context) -> Any:
from airflow.utils.operator_helpers import make_kwargs_callable
# Remove "logical_date" because it is already a mandatory positional
argument
- logical_date = context["logical_date"]
+ logical_date = (
Review Comment:
Thanks for the feedback, @gopidesupavan!
I've pulled that date-fallback logic into a new private helper
_get_logical_date(context), and updated _handle_execution_date_fn to call it.
• Added _get_logical_date in external_task.py
• Refactored _handle_execution_date_fn to delegate there
• Updated and added unit tests in test_external_task_sensor.py
• Ran pre-commit and fixed formatting/imports
All tests are now passing locally and CI is green. Please let me know if
you'd like any more tweaks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
