dingo4dev commented on code in PR #52431:
URL: https://github.com/apache/airflow/pull/52431#discussion_r2179441841
##########
providers/standard/src/airflow/providers/standard/sensors/external_task.py:
##########
@@ -522,6 +522,28 @@ def get_external_task_group_task_ids(self, session,
dttm_filter):
dttm_filter, self.external_task_group_id, self.external_dag_id,
session
)
+ def _get_logical_date(self, context) -> datetime.datetime:
Review Comment:
I’m bringing this considered question forward because my PR
https://github.com/apache/airflow/pull/52237 isn’t getting any ATTENTION.
The caller `_get_dttm_filter` is already handling the compatibility
retrieval for `logical_date`. Why not replace this on the caller and pass the
`logical_date` to `_handle_execution_date_fn` as args.
https://github.com/apache/airflow/blob/460b1c65748016b069f39fa61210db254176d914/providers/standard/src/airflow/providers/standard/sensors/external_task.py#L261-L273
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
