ephraimbuddy commented on code in PR #52876:
URL: https://github.com/apache/airflow/pull/52876#discussion_r2191692810
##########
providers/amazon/src/airflow/providers/amazon/aws/bundles/s3.py:
##########
@@ -137,10 +137,20 @@ def refresh(self) -> None:
)
def view_url(self, version: str | None = None) -> str | None:
+ """
+ Return a URL for viewing the DAGs in S3. Currently, versioning is not
supported.
+
+ This method is deprecated and will be removed in a future release. Use
`view_url_template` instead.
+ """
+ return self.view_url_template()
+
+ def view_url_template(self) -> str | None:
"""Return a URL for viewing the DAGs in S3. Currently, versioning is
not supported."""
if self.version:
raise AirflowException("S3 url with version is not supported")
-
+ if hasattr(self, "_view_url_template") and self._view_url_template:
+ # Backward compatibility for released Airflow versions
+ return self._view_url_template
Review Comment:
Airflow 3.0.2 for example doesn't have the `_view_url_template`. If this
provider is released and used in `3.0.2`, it will raise errors
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
