ephraimbuddy commented on code in PR #52876:
URL: https://github.com/apache/airflow/pull/52876#discussion_r2185673982
##########
providers/git/src/airflow/providers/git/bundles/git.py:
##########
@@ -247,3 +246,41 @@ def view_url(self, version: str | None = None) -> str |
None:
if host == allowed_host or host.endswith(f".{allowed_host}"):
return template
return None
+
+ def view_url_template(self) -> str | None:
Review Comment:
There's a little difference that won't allow us refactor this: the
view_url_template returns a template while view_url doesn't return a template
but full url. Changing it to return a template would be a breaking change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
