ephraimbuddy commented on code in PR #52876:
URL: https://github.com/apache/airflow/pull/52876#discussion_r2194651280
##########
airflow-core/src/airflow/dag_processing/bundles/base.py:
##########
@@ -316,10 +323,31 @@ def view_url(self, version: str | None = None) -> str |
None:
URL to view the bundle on an external website. This is shown to users
in the Airflow UI, allowing them to navigate to this url for more details about
that version of the bundle.
This needs to function without `initialize` being called.
-
:param version: Version to view
:return: URL to view the bundle
"""
+ warnings.warn(
+ "The 'view_url' method is deprecated and will be removed in a
future version. "
+ "Use 'view_url_template' instead.",
Review Comment:
The `render_url` is `DagBundleModel`'s method and not
`BaseDagBundle/DagBundle` method. The deprecation on Bundle manager suggested
render_url which is more appropriate there
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
