ephraimbuddy commented on code in PR #52876:
URL: https://github.com/apache/airflow/pull/52876#discussion_r2194694480
##########
providers/amazon/src/airflow/providers/amazon/aws/bundles/s3.py:
##########
@@ -137,10 +137,20 @@ def refresh(self) -> None:
)
def view_url(self, version: str | None = None) -> str | None:
+ """
+ Return a URL for viewing the DAGs in S3. Currently, versioning is not
supported.
+
+ This method is deprecated and will be removed in a future release. Use
`view_url_template` instead.
Review Comment:
Yeah. I added deprecation warning before and it a lot of
`pytest.warns(AirflowProviderDeprecationWarning)` in core tests/providers tests
and I decided to remove it. Here's the commits:
https://github.com/apache/airflow/pull/52876/commits/74c3eb8e214db8faf83958a9c89ed38656548f3b
and
https://github.com/apache/airflow/pull/52876/commits/74c3eb8e214db8faf83958a9c89ed38656548f3b.
Should I add it back or just leave a comment about the deprecation version
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
