bugraoz93 commented on code in PR #52177:
URL: https://github.com/apache/airflow/pull/52177#discussion_r2198073615
##########
airflow-core/src/airflow/ui/src/components/Clear/TaskInstance/ClearTaskInstanceDialog.tsx:
##########
@@ -140,7 +142,28 @@ const ClearTaskInstanceDialog = ({ onClose, open,
taskInstance }: Props) => {
/>
</Flex>
<ActionAccordion affectedTasks={affectedTasks} note={note}
setNote={setNote} />
- <Flex justifyContent="end" mt={3}>
+ <Flex
+ {...(taskInstance.dag_version.bundle_version !== null &&
Review Comment:
Should we make this consistent with the db? I think it is nullable on Dag
level and foreign keys could end up null instead. I may be missing something
and shouldn't have it necessary to be in this PR, too
https://github.com/apache/airflow/blob/5b8f631c5e0d66e589bd54ff7b5526d485398ad0/airflow-core/src/airflow/migrations/versions/0050_3_0_0_add_dagbundlemodel.py#L53
##########
airflow-core/src/airflow/ui/src/components/Clear/TaskInstance/ClearTaskInstanceDialog.tsx:
##########
@@ -140,7 +142,28 @@ const ClearTaskInstanceDialog = ({ onClose, open,
taskInstance }: Props) => {
/>
</Flex>
<ActionAccordion affectedTasks={affectedTasks} note={note}
setNote={setNote} />
- <Flex justifyContent="end" mt={3}>
+ <Flex
+ {...(taskInstance.dag_version.bundle_version !== null &&
Review Comment:
Should we make this consistent with the db? I think it is nullable on Dag
level and foreign keys could end up null instead. I may be missing something
and shouldn't have it necessary to be in this PR, too
https://github.com/apache/airflow/blob/5b8f631c5e0d66e589bd54ff7b5526d485398ad0/airflow-core/src/airflow/migrations/versions/0050_3_0_0_add_dagbundlemodel.py#L53
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
