jedcunningham commented on code in PR #52177:
URL: https://github.com/apache/airflow/pull/52177#discussion_r2198544227
##########
airflow-core/src/airflow/ui/public/i18n/locales/en/dags.json:
##########
@@ -62,6 +62,7 @@
"onlyFailed": "Clear only failed tasks",
"past": "Past",
"queueNew": "Queue up new tasks",
+ "runOnLatestVersion": "Run with latest version",
Review Comment:
```suggestion
"runOnLatestVersion": "Run with latest bundle version",
```
Probably worth being more specific that this is the bundle version?
##########
airflow-core/src/airflow/ui/openapi-gen/requests/schemas.gen.ts:
##########
@@ -1205,6 +1205,11 @@ export const $ClearTaskInstancesBody = {
type: 'boolean',
title: 'Include Past',
default: false
+ },
+ run_on_latest_version: {
+ type: 'boolean',
+ title: 'Run On Latest Version',
Review Comment:
```suggestion
title: 'Run on latest bundle version',
```
##########
airflow-core/src/airflow/cli/cli_config.py:
##########
@@ -340,6 +340,14 @@ def string_lower_type(val):
),
choices=("none", "completed", "failed"),
)
+ARG_BACKFILL_RUN_ON_LATEST_VERSION = Arg(
+ ("--run-on-latest-version",),
+ help=(
+ "(Experimental) If set, the backfill will run tasks using the latest
DAG version instead of "
+ "the version that was active when the original DAG run was created."
Review Comment:
```suggestion
"the version that was active when the original Dag run was created."
```
##########
airflow-core/src/airflow/ui/openapi-gen/requests/schemas.gen.ts:
##########
@@ -2205,6 +2210,11 @@ export const $DAGRunClearBody = {
type: 'boolean',
title: 'Only Failed',
default: false
+ },
+ run_on_latest_version: {
+ type: 'boolean',
+ title: 'Run On Latest Version',
Review Comment:
```suggestion
title: 'Run on latest bundle version',
```
##########
airflow-core/src/airflow/ui/src/components/Clear/Run/ClearRunDialog.tsx:
##########
@@ -101,7 +102,23 @@ const ClearRunDialog = ({ dagRun, onClose, open }: Props)
=> {
/>
</Flex>
<ActionAccordion affectedTasks={affectedTasks} note={note}
setNote={setNote} />
- <Flex justifyContent="end" mt={3}>
+ <Flex
+ {...(dagRun.bundle_version !== null && dagRun.bundle_version !== ""
Review Comment:
We should hide it (or precheck and disable with a tooltip) if it's already
the latest version?
##########
airflow-core/src/airflow/cli/cli_config.py:
##########
@@ -340,6 +340,14 @@ def string_lower_type(val):
),
choices=("none", "completed", "failed"),
)
+ARG_BACKFILL_RUN_ON_LATEST_VERSION = Arg(
+ ("--run-on-latest-version",),
+ help=(
+ "(Experimental) If set, the backfill will run tasks using the latest
DAG version instead of "
Review Comment:
```suggestion
"(Experimental) If set, the backfill will run tasks using the latest
bundle version instead of "
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
