o-nikolas commented on code in PR #53215:
URL: https://github.com/apache/airflow/pull/53215#discussion_r2208804452
##########
airflow-core/src/airflow/models/deadline.py:
##########
@@ -98,6 +98,61 @@ def _determine_resource() -> tuple[str, str]:
f"{self.deadline_time} or run: {self.callback}({callback_kwargs})"
)
+ @classmethod
+ @provide_session
+ def remove_deadlines(cls, *, session: Session, conditions: dict[Column,
Any]) -> int:
+ """
+ Remove deadlines from the table which match the provided conditions
and return the number removed.
+
+ NOTE: This should only be used to remove deadlines which are
associated with
+ successful dagruns. If the deadline was missed, move it to the
`missed_deadlines`
+ table after executing the callback.
Review Comment:
Yeah synced with Ramit about the table vs column, that all sounds good. If
that happens elsewhere I guess this function name is good enough. Although, I
will note that it is still quite conditional in some cases not all, or even
any, deadlines will be deleted. So it's more like a prune (which is a name you
suggested when we chatted in Slack and I like that).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
