o-nikolas commented on code in PR #53215:
URL: https://github.com/apache/airflow/pull/53215#discussion_r2208808459
##########
airflow-core/tests/unit/models/test_deadline.py:
##########
@@ -103,6 +105,50 @@ def test_add_deadline(self, dagrun, session):
assert result.callback == deadline_orm.callback
assert result.callback_kwargs == deadline_orm.callback_kwargs
+ @pytest.mark.parametrize(
+ "conditions",
+ [
+ pytest.param({}, id="empty_conditions"),
+ pytest.param({Deadline.dagrun_id: INVALID_RUN_ID},
id="no_matches"),
+ pytest.param({Deadline.dagrun_id: RUN_ID}, id="single_condition"),
+ pytest.param({Deadline.dagrun_id: RUN_ID, Deadline.dag_id:
DAG_ID}, id="multiple_conditions"),
+ pytest.param(
+ {Deadline.dagrun_id: RUN_ID, Deadline.dag_id: INVALID_DAG_ID},
id="mixed_conditions"
+ ),
+ ],
+ )
+ @mock.patch("sqlalchemy.orm.Session")
+ def test_resolve_deadlines(self, mock_session, conditions):
Review Comment:
Yeah, rename was the suggestion for sure! I should have been more clear
:pray:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
