potiuk commented on PR #53417: URL: https://github.com/apache/airflow/pull/53417#issuecomment-3085658975
Yep. I wil take a look tomorrow/over weekend. > I wonder how imports between shared modules should work in this approach. This could be done as symlinks between shared modules - but I also think such imports should be discouraged. I think each shared module should be independent from each other - because that is what adspds complexithy. For example - rather than reading a configuration from logging module - you should pass a parameter from outside that provides the config. Generally spekaing - "needin ag one shared module to use another shared module" is an antipattern that shold be possible when really neede, but it should be avoided. This is waht cyclomatic complexity "theory" is about when turned into practice (as far as I understand it). It you look at breeze code this is how the whole package is organized like. there are about 30 independent modules that do not use each other, whenever there is a need to share things, the shared things are moved into a "one level deep" module that is imported by other modules (global constants is a good example of it). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
