ashb commented on PR #53417: URL: https://github.com/apache/airflow/pull/53417#issuecomment-3089294862
> Generally speaking - "needing a one shared module to use another shared module" is an antipattern that should be possible when really needed, but it should be avoided. That is an opinion I don't agree with. Quite the oppsite in fact: I think it is very likely we will want to use the "timezone" shared lib (utcnow, date parsing) across many of the other shared libs. (Kube pod to parse logs, logging to deal with formatting are the first two that spring to mind) However "should be possible when needed" -- I don't think it is. I can't think what you would put in, say the logging/structlog.py code that would work in all cases (inside core, inside task-sdk and inside it's own shared tests) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
