pierrejeambrun commented on code in PR #53064:
URL: https://github.com/apache/airflow/pull/53064#discussion_r2216429343
##########
airflow-core/src/airflow/ui/src/pages/Dag/Header.tsx:
##########
@@ -108,7 +111,34 @@ export const Header = ({
/>
)}
<FavoriteDagButton dagId={dag.dag_id} withText={true} />
- <ParseDag dagId={dag.dag_id} fileToken={dag.file_token} />
+ <Menu.Root>
+ <Menu.Trigger asChild>
+ <Button aria-label={translate("dag:header.buttons.advanced")}
variant="outline">
+ <LuMenu />
+ </Button>
+ </Menu.Trigger>
+ <Portal>
+ <Menu.Positioner>
+ <Menu.Content>
+ <Menu.Item value="reparse">
+ <div style={{ width: "100%" }}>
Review Comment:
You can apply the width to the outer element and change the react fragment
into a `Box` container and apply the width there, that should solve your issue.
##########
airflow-core/src/airflow/ui/src/pages/Dag/Header.tsx:
##########
@@ -108,7 +111,34 @@ export const Header = ({
/>
)}
<FavoriteDagButton dagId={dag.dag_id} withText={true} />
- <ParseDag dagId={dag.dag_id} fileToken={dag.file_token} />
+ <Menu.Root>
+ <Menu.Trigger asChild>
+ <Button aria-label={translate("dag:header.buttons.advanced")}
variant="outline">
+ <LuMenu />
+ </Button>
+ </Menu.Trigger>
+ <Portal>
+ <Menu.Positioner>
+ <Menu.Content>
+ <Menu.Item value="reparse">
+ <div style={{ width: "100%" }}>
Review Comment:
You don't need that. It's because of the fragment that is inside the
`DeleteDagButton`.
##########
airflow-core/src/airflow/ui/src/components/DagActions/DeleteDagButton.tsx:
##########
@@ -51,8 +59,9 @@ const DeleteDagButton = ({ dagDisplayName, dagId, withText =
true }: DeleteDagBu
icon={<FiTrash2 />}
onClick={onOpen}
text={translate("dagActions.delete.button")}
- variant="solid"
+ variant={variant}
withText={withText}
+ {...(Boolean(width) ? { width } : {})}
Review Comment:
You can do that directly
```suggestion
{...rest}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
