Jasperora commented on code in PR #53064:
URL: https://github.com/apache/airflow/pull/53064#discussion_r2213782520
##########
airflow-core/src/airflow/ui/src/components/DagActions/DeleteDagButton.tsx:
##########
@@ -51,7 +57,7 @@ const DeleteDagButton = ({ dagDisplayName, dagId, withText =
true }: DeleteDagBu
icon={<FiTrash2 />}
onClick={onOpen}
text={translate("dagActions.delete.button")}
- variant="solid"
+ variant={variant}
Review Comment:
Hi @pierrejeambrun. Sorry my reply last time was unclear and wrong. In
`FavoriteDagButton.tsx`, the variant of `ActionButton` is not specified.
However in `DeleteDagButton.tsx`, variant of `ActionButton` is specified to be
"solid". I've tried that if we don't pass variant to it, the button would be
solid.
Alternative way is to change the default value of variant in
`DeleteDagButton.tsx` or remove the specified value "solid". However, I think
this would be a worse method since it would affect all the other
`DeleteDagButton`.
I guess it's because `DeleteDagButton` is not previously used in header, the
variant is designed to be "solid" when `withText` is True. Thus I think passing
variant is necessary.
As for css props, I've tried `width="100%"` but it doesn't work. Still
trying to figure it out.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
