amoghrajesh commented on code in PR #53435:
URL: https://github.com/apache/airflow/pull/53435#discussion_r2221365195
##########
airflow-core/src/airflow/jobs/scheduler_job_runner.py:
##########
@@ -2016,7 +2017,7 @@ def _maybe_requeue_stuck_ti(self, *, ti, session):
extra=f"Task was requeued more than
{self._num_stuck_queued_retries} times and will be failed.",
)
)
- ti.set_state(TaskInstanceState.FAILED, session=session)
+ executor.fail(ti.key)
Review Comment:
I agree with Niko here. While it gets the job done, it does it in an
inefficient manner.
Really appreciate the work done here, but I will also be in favour of
calling `executor.fail` as well as `self.change_state`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
