o-nikolas commented on code in PR #53435:
URL: https://github.com/apache/airflow/pull/53435#discussion_r2223824879
##########
airflow-core/src/airflow/jobs/scheduler_job_runner.py:
##########
@@ -2016,7 +2017,7 @@ def _maybe_requeue_stuck_ti(self, *, ti, session):
extra=f"Task was requeued more than
{self._num_stuck_queued_retries} times and will be failed.",
)
)
- ti.set_state(TaskInstanceState.FAILED, session=session)
+ executor.fail(ti.key)
Review Comment:
Thanks for testing that! I was curious if it would work or not. I would
prefer we generate a TaskCallbackRequest for this new usecase then, since again
using the drift mechanism does not _feel_ right to me. However, I know that's
much more work and testing, so if you wanted to push back on that and merge
what you have now and others agree, I'm happy to commit to that :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
