eladkal commented on code in PR #53126:
URL: https://github.com/apache/airflow/pull/53126#discussion_r2223008509
##########
providers/cncf/kubernetes/src/airflow/providers/cncf/kubernetes/hooks/kubernetes.py:
##########
@@ -93,6 +93,7 @@ class KubernetesHook(BaseHook, PodOperatorHookProtocol):
:param cluster_context: Optionally specify a context to use (e.g. if you
have multiple
in your kubeconfig.
:param config_file: Path to kubeconfig file.
+ :param config_dict: Takes the config file as a dict.
Review Comment:
I rather we won't need to explain anything.
The claim of dict and file are quite different is from what point of view?
This is a user facing interface. If I wear my user hat I care about providing
config that is it. Thus I am hoping for a single "entry point". I see no
different between this case and the Sql operators where we provide query as
text vs query as file or query as a list of strings. From a user prespective
who wants to submit a query these are all the same.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
