potiuk commented on code in PR #53126:
URL: https://github.com/apache/airflow/pull/53126#discussion_r2229666278
##########
providers/cncf/kubernetes/src/airflow/providers/cncf/kubernetes/hooks/kubernetes.py:
##########
@@ -93,6 +93,7 @@ class KubernetesHook(BaseHook, PodOperatorHookProtocol):
:param cluster_context: Optionally specify a context to use (e.g. if you
have multiple
in your kubeconfig.
:param config_file: Path to kubeconfig file.
+ :param config_dict: Takes the config file as a dict.
Review Comment:
I think dict and file are quire different. Dict is part of the code, where
File needs to present on the filesystem. Or mounted from secrets on K8S.
This means for example that you can have different configs on dev/prod even
if you use the same Dag - simply because they are executed in different
environment. Not so with the dict - there you have to deliberately change the
content in the parsing code. So I think those two cases are different and if
we can combine them, that gives quite flexible options for the users.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
