prakass1 commented on code in PR #53358:
URL: https://github.com/apache/airflow/pull/53358#discussion_r2226082452
##########
chart/templates/dag-processor/dag-processor-deployment.yaml:
##########
@@ -46,8 +46,8 @@ metadata:
release: {{ .Release.Name }}
chart: "{{ .Chart.Name }}-{{ .Chart.Version }}"
heritage: {{ .Release.Service }}
- {{- with .Values.labels }}
- {{- toYaml . | nindent 4 }}
+ {{- if or (.Values.labels) (.Values.dagProcessor.labels) }}
Review Comment:
Please revert the heritage at release to be old values as they are only
taken from .Values.labels which is already implemented for dagProcessor
deployment, and also applicable to other services.
https://github.com/apache/airflow/blob/main/chart/templates/dag-processor/dag-processor-deployment.yaml#L49
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
