prakass1 commented on code in PR #53358:
URL: https://github.com/apache/airflow/pull/53358#discussion_r2223539567
##########
chart/values.schema.json:
##########
@@ -3711,6 +3711,21 @@
],
"default": null
},
+ "labels": {
+ "description": "Labels to add to the DagProcessor.",
+ "type": "object",
+ "propertyNames": {
+ "type": "string",
+ "pattern":
"^([A-Za-z0-9]([-A-Za-z0-9]*[A-Za-z0-9])?)(/[A-Za-z0-9]([-A-Za-z0-9]*[A-Za-z0-9])?)?$",
+ "description": "Valid Kubernetes label key (with
optional DNS prefix)."
+ },
+ "additionalProperties": {
+ "type": "string",
+ "pattern":
"^[A-Za-z0-9]([-A-Za-z0-9_.]*[A-Za-z0-9])?$",
+ "description": "Valid Kubernetes label value."
+ },
+ "default": {}
+ },
Review Comment:
Please add the following:
```json
"labels": {
"description": "Labels to add to the dagProcessor objects and pods.",
"type": "object",
"default": {},
"additionalProperties": {
"type": "string"
}
},
```
after "podAnnotations". This will in such a way maintains the consistency of
the schema across the services. Further, this should allow passing the test.
##########
chart/values.schema.json:
##########
@@ -3711,6 +3711,21 @@
],
"default": null
},
+ "labels": {
+ "description": "Labels to add to the DagProcessor.",
+ "type": "object",
+ "propertyNames": {
+ "type": "string",
+ "pattern":
"^([A-Za-z0-9]([-A-Za-z0-9]*[A-Za-z0-9])?)(/[A-Za-z0-9]([-A-Za-z0-9]*[A-Za-z0-9])?)?$",
+ "description": "Valid Kubernetes label key (with
optional DNS prefix)."
+ },
+ "additionalProperties": {
+ "type": "string",
+ "pattern":
"^[A-Za-z0-9]([-A-Za-z0-9_.]*[A-Za-z0-9])?$",
+ "description": "Valid Kubernetes label value."
+ },
+ "default": {}
+ },
Review Comment:
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
