vincbeck commented on code in PR #53577:
URL: https://github.com/apache/airflow/pull/53577#discussion_r2242925887


##########
scripts/ci/pre_commit/compile_provider_assets.py:
##########
@@ -60,18 +66,18 @@ def get_directory_hash(directory: Path, skip_path_regexps: 
list[str]) -> str:
 SKIP_PATH_REGEXPS = [".*/node_modules.*"]
 
 
-def compile_assets(www_directory: Path):
-    dist_directory = www_directory / "static" / "dist"
-    FAB_PROVIDER_WWW_HASH_FILE.parent.mkdir(exist_ok=True, parents=True)
+def compile_assets(provider_name: str):
+    provider_paths = PROVIDERS_PATHS[provider_name]

Review Comment:
   Maybe error out with a nice error message if `provider_name` is not in 
`PROVIDERS_PATHS`? This is something that can happen I guess



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to