jscheffl commented on code in PR #53577:
URL: https://github.com/apache/airflow/pull/53577#discussion_r2243785574
##########
scripts/ci/pre_commit/compile_provider_assets.py:
##########
@@ -94,10 +104,10 @@ def compile_assets(www_directory: Path):
sys.exit(result.returncode)
subprocess.check_call(["yarn", "run", "build"],
cwd=os.fspath(www_directory), env=env)
new_hash = get_directory_hash(www_directory,
skip_path_regexps=SKIP_PATH_REGEXPS)
- FAB_PROVIDER_WWW_HASH_FILE.write_text(new_hash + "\n")
+ provider_paths["hash"].write_text(new_hash + "\n")
print(f"Assets compiled successfully. New hash: {new_hash}")
if __name__ == "__main__":
Review Comment:
Second feedback is covering the check for arg lengths
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
