amoghrajesh commented on code in PR #53514:
URL: https://github.com/apache/airflow/pull/53514#discussion_r2250696460


##########
airflow-core/src/airflow/jobs/triggerer_job_runner.py:
##########
@@ -419,6 +429,8 @@ def _handle_request(self, msg: ToTriggerSupervisor, log: 
FilteringBoundLogger, r
                 dump_opts = {"exclude_unset": True, "by_alias": True}
             else:
                 resp = conn
+        elif isinstance(msg, DeleteVariable):
+            self.client.variables.delete(msg.key)

Review Comment:
   ```suggestion
               resp = self.client.variables.delete(msg.key)
   ```
   
   I request you to follow the shared reference (same mechanism used in 
supervisor & dag processor). The response catch here does something and is 
needed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to