karenbraganz commented on code in PR #53514: URL: https://github.com/apache/airflow/pull/53514#discussion_r2246549371
########## airflow-core/tests/unit/jobs/test_triggerer_job.py: ########## @@ -687,8 +712,8 @@ def handle_events(self): @pytest.mark.asyncio @pytest.mark.execution_timeout(20) -async def test_trigger_can_access_variables_connections_and_xcoms(session, dag_maker): - """Checks that the trigger will successfully access Variables, Connections and XComs.""" +async def test_trigger_can_call_variables_connections_and_xcoms_methods(session, dag_maker): Review Comment: @amoghrajesh I made the changes you suggested to the tests. I was hesitant to do it this way because it doesn't actually check the DB to determine whether the Variable and XCom have been set or deleted successfully. It's only passing the value or key that was set or deleted. However, this seems like most viable way to write the test. I also manually tested my code by setting and deleting Variables and XComs in a trigger that I ran. I verified that the Variables and XComs actually got set and deleted on the Airflow UI. Lmk if you have any other feedback about the code or tests or if it's good to merge. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
