xBis7 commented on code in PR #53722:
URL: https://github.com/apache/airflow/pull/53722#discussion_r2253712781


##########
airflow-core/src/airflow/config_templates/config.yml:
##########
@@ -1050,6 +1050,15 @@ metrics:
       example: "\"scheduler,executor,dagrun,pool,triggerer,celery\"
         or \"^scheduler,^executor,heartbeat|timeout\""
       default: ""
+    legacy_names_on:
+      description: |
+        If true, it exports both new and legacy metric names.
+        Legacy names contain variables such as dag_id and task_id, which 
increases cardinality.
+        The new names set these variables inside tags.

Review Comment:
   The distinct names will be decreased but the number of different metrics 
will be the same. So from that point of view, there is no change in 
cardinality. I see how that comment can be misinterpreted.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to