xBis7 commented on code in PR #53722:
URL: https://github.com/apache/airflow/pull/53722#discussion_r2254048244


##########
devel-common/src/tests_common/test_utils/otel_utils.py:
##########
@@ -94,14 +95,23 @@ def clean_task_lines(lines: list) -> list:
     return cleaned_lines
 
 
-def extract_spans_from_output(output_lines: list):
+def _extract_obj_from_output(output_lines: list[str], kind: str):
     """
-    For a given list of ConsoleSpanExporter output lines, it extracts the json 
spans and creates two dictionaries.
-
-    :return: root spans dict (key: root_span_id - value: root_span), spans 
dict (key: span_id - value: span)
+    Used to extract spans or metrics from the output.
+
+    Parameters
+    ----------
+    output_lines : list[str]
+        The captured stdout split into lines.
+    kind : "spans" | "metrics"
+        Which json type to extract from the output.

Review Comment:
   Done.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to