dstandish commented on PR #53492: URL: https://github.com/apache/airflow/pull/53492#issuecomment-3167965635
This query is a million times better, thank you. The other one was just like, not acceptable. It was too messy to be reasonably understood. This one, it's fine. You can understand what it is doing. And that is important. Because now we can look at it and understand it and think about what it is doing, and evaluate whether we like it. And now that we can do that, one observation. This query is not a starvation panacea, I don't think. For example what if there are two conditions interplaying. Suppose there's only one pool slot available in pool A. Tasks X and Y have pool A. Task X sorts first. So task Y would be filtered out by the pool constraint. But suppose further that for task X, total_tis_per_dagrun_count is beyond dag max active tasks. So nothing will be scheduled for pool A even though Y should be scheduled. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
