Asquator commented on PR #53492:
URL: https://github.com/apache/airflow/pull/53492#issuecomment-3168943144

   > @dstandish
   > 
   > > This query is not a starvation panacea, I don't think.
   > > For example what if there are two conditions interplaying.
   > > Suppose there's only one pool slot available in pool A.  Tasks X and Y 
have pool A.  Task X sorts first.  So task Y would be filtered out by the pool 
constraint.
   > 
   > If task x sorts first it means its at a higher priority and needs to be 
run first, which is expected behaviour, I may have not fully understood what 
the problem here, and I would appreciate it if you could clarify further
   > 
   > > But suppose further that for task X, total_tis_per_dagrun_count is 
beyond dag max active tasks.  So nothing will be scheduled for pool A even 
though Y should be scheduled.
   > 
   
   @Nataneljpwd 
   > That is a good point, however, I don't think this case can happen as the 
query won't allow more than dag Max active tasks to be run for a specific day, 
correct me if I'm wrong and if you think I didn't undestand. In this case task 
x is filtered out and task y is checked
   
   The fear is that row_number() will be less than #pool slots, so Y won't be 
even looked at. I think we whether must nest or find another way to cope with 
the situation. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to