jason810496 commented on code in PR #54510:
URL: https://github.com/apache/airflow/pull/54510#discussion_r2277084299
##########
airflow-core/src/airflow/utils/serve_logs/core.py:
##########
@@ -54,11 +54,11 @@ def serve_logs(port=None):
logger.info("Starting log server on %s", serve_log_uri)
# Use uvicorn directly for ASGI applications
- uvicorn.run("airflow.utils.serve_logs.log_server:app", host=host,
port=port, workers=2, log_level="info")
# Note: if we want to use more than 1 workers, we **can't** use the
instance of FastAPI directly
- # This is way we split the instantiation of log server to a separate module
+ # This is why we split the instantiation of log server to a separate module
#
#
https://github.com/encode/uvicorn/blob/374bb6764e8d7f34abab0746857db5e3d68ecfdd/docs/deployment/index.md?plain=1#L50-L63
+ uvicorn.run("airflow.utils.serve_logs.log_server:app", host=host,
port=port, workers=1, log_level="info")
Review Comment:
Cool, thanks for the confirmation.
It would be great to raise another issue to track this behavior.
This means there _might not_ be uvicorn issue but other changes in Airflow
that cause this error.
Since there is not problem on 3.0.4 but has error on latest main branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
