viiccwen commented on code in PR #54555:
URL: https://github.com/apache/airflow/pull/54555#discussion_r2280329715
##########
airflow-core/tests/unit/core/test_logging_config.py:
##########
@@ -365,3 +474,40 @@ def test_loading_remote_logging_with_hdfs_handler(self):
airflow.logging_config.configure_logging()
assert isinstance(airflow.logging_config.REMOTE_TASK_LOG,
HdfsRemoteLogIO)
+
+ @pytest.mark.parametrize(
+ "settings_content,module_structure,expected_path",
+ [
+ (SETTINGS_FILE_SIMPLE_MODULE, None,
f"{SETTINGS_DEFAULT_NAME}.LOGGING_CONFIG"),
+ (
+ SETTINGS_FILE_NESTED_MODULE,
+ "nested.config.module",
+ f"nested.config.module.{SETTINGS_DEFAULT_NAME}.LOGGING_CONFIG",
+ ),
+ ],
+ )
+ def test_load_logging_config_module_paths(self, settings_content,
module_structure, expected_path):
Review Comment:
thx!
##########
airflow-core/tests/unit/core/test_logging_config.py:
##########
@@ -191,6 +293,13 @@ def teardown_method(self):
importlib.reload(airflow_local_settings)
configure_logging()
+ def _verify_basic_logging_config(self, logging_config, logging_class_path,
expected_path):
Review Comment:
thx!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
