amichai07 commented on a change in pull request #4751: [AIRFLOW-3607] collected
trigger rule dep check per dag run
URL: https://github.com/apache/airflow/pull/4751#discussion_r344499197
##########
File path: airflow/utils/state.py
##########
@@ -99,6 +99,7 @@ def finished(cls):
cls.SUCCESS,
cls.FAILED,
cls.SKIPPED,
+ cls.UPSTREAM_FAILED
Review comment:
Are you sure it doesn't make sense?
It makes sense to me in a meaning that this is a task which its state is
already set, and in most places it is considered exactly as failed . I searched
for occurrences in the code that might challenge this perception and I didn't
find any.
Anyway if you think it's better I can change it back and not use
state.finished() it in my function.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
