amichai07 commented on a change in pull request #4751: [AIRFLOW-3607] collected
trigger rule dep check per dag run
URL: https://github.com/apache/airflow/pull/4751#discussion_r347492605
##########
File path: airflow/ti_deps/dep_context.py
##########
@@ -67,6 +67,8 @@ class DepContext:
:type ignore_task_deps: bool
:param ignore_ti_state: Ignore the task instance's previous failure/success
:type ignore_ti_state: bool
+ :param finished_tasks: A list of all the finished tasks of this run
+ :type finished_tasks: list of airflow.models.TaskInstance
Review comment:
Ok I checked it, I suggest a change that will solve this and the following
comment concerning "dag_run_finished_ti_map" collection. I think it will be
both cleaner and more efficient.
LMK what you think about this direction and will arrange it a bit better if
you think its good.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
