bbovenzi commented on code in PR #53981: URL: https://github.com/apache/airflow/pull/53981#discussion_r2283226502
########## airflow-core/src/airflow/ui/src/theme/react_components_analysis.md: ########## @@ -0,0 +1,183 @@ +# Airflow UI React Components Analysis + +## Overview +This document analyzes all React components, pages, and layouts in the Airflow UI codebase to identify those that are not following Chakra UI best practices and the custom Chakra UI theme defined in `src/theme.ts`. + +## Theme Structure +The custom theme defines semantic color tokens for: +- **Airflow Task States**: success, failed, queued, skipped, up_for_reschedule, up_for_retry, upstream_failed, running, restarting, deferred, scheduled, none, removed +- **Color Palettes**: red, orange, amber, yellow, lime, green, emerald, teal, cyan, sky, blue, indigo, violet, purple, fuchsia, pink, rose, slate, gray, zinc, neutral, stone +- **Special Tokens**: navbar + +## Components Directory + +### Root Level Components Review Comment: What's the point of listing all these components? I feel like this isn't reasonable to maintain. Why don't we want to check for semantic colors in every .tsx file? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
