bbovenzi commented on code in PR #53981:
URL: https://github.com/apache/airflow/pull/53981#discussion_r2283234113
##########
airflow-core/src/airflow/api_fastapi/auth/managers/simple/ui/src/login/Login.tsx:
##########
@@ -52,6 +52,24 @@ export const Login = () => {
localStorage.getItem(LOCAL_STORAGE_DISABLE_BANNER_KEY),
);
+ // Set page title for SEO
+ useEffect(() => {
+ document.title = "Sign In - Apache Airflow";
Review Comment:
But this is the login for someone's airflow instance. We don't need SEO?
Also, isn't the title already set in the index.html?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
