pierrejeambrun commented on code in PR #54341:
URL: https://github.com/apache/airflow/pull/54341#discussion_r2285632742
##########
airflow-core/src/airflow/api_fastapi/common/parameters.py:
##########
@@ -448,6 +449,38 @@ def depends(cls, owners: list[str] =
Query(default_factory=list)) -> _OwnersFilt
return cls().set_value(owners)
+class _TimetableTypesFilter(BaseParam[list[str]]):
+ """Filter on timetable type."""
+
+ def to_orm(self, select: Select) -> Select:
+ if self.skip_none is False:
+ raise ValueError(f"Cannot set 'skip_none' to False on a
{type(self)}")
+
+ if not self.value: # No filter provided
+ return select
+
+ select = select.join(SerializedDagModel, SerializedDagModel.dag_id ==
DagModel.dag_id)
+
+ # JSON path for timetable type
+ json_path = "$.dag.timetable.__type"
Review Comment:
Considering the fact that pagination + filtering is involved based on
additional criterias, I think that we should go for 1) since this is the only
one that will support it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
