potiuk commented on code in PR #54449: URL: https://github.com/apache/airflow/pull/54449#discussion_r2287759585
########## shared/secrets_masker/pyproject.toml: ########## @@ -0,0 +1,47 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +[project] +name = "apache-airflow-shared-secrets_masker" +description = "Shared secrets masker code for Airflow distributions" +version = "0.0" +classifiers = [ + "Private :: Do Not Upload", +] + +dependencies = [ + # No external dependencies - only standard library +] Review Comment: > Never realised because I was running tests from an activate env Yes. This is the **cooolest** feature of `uv` that it can both have a "complete workspace environment" when you run `uv` in the main dir, but when you run it in the distribution - it switches to the "isolated" mode - where we only sync and have access to the dependencies that are **actually** declared in the distribution - and nothing else. What happens in this case `uv` performs `uv sync` and only syncs what the `pyproject.toml` of that distribution declares - and it will include the dependencies from the workspace - but only if they are declared (explicitly or transitively) in the pyproject.toml of the distribution that we are currently "in". It's super nice and we are already using it with "Lowest deps" tests in the CI - that's wy we are pretty certain that our provider's distributions do not miss any dependencies. Wha the "Lowest deps" test basically does is: ```bash cd providers/<PROVIDER> uv sync --resolution lowest-direct uv run pytest ``` (roughly) This only uses direct dependencies of the provider + dev dependencies of the provider and lowers-them down to the floor for direct dependencies. So if we miss any dependency declared in a particular provider, or any development dependency it needs (and which is missing in devel-common) - this test will fail. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
