amoghrajesh commented on PR #54449:
URL: https://github.com/apache/airflow/pull/54449#issuecomment-3206796178
Ok i got back to it and did some cleaning up too. Will post a tldr tomorrow,
but basic idea is that I moved the `MASK_SECRET_IN_LOGS` to the SecretMasker as
a class varibale instead of it being in settings.
I want to chop off the remaining dependencies on secret_masker in pyproject
too, but right now secrets masker is in some ways bound to it, so i will try it
out maybe tomorrow
Error I am dealing with:
```
tests/secrets_masker/test_secrets_masker.py:996: in test_merge_max_depth
result = merge(new_data, old_data, max_depth=1)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
src/airflow_shared/secrets_masker/secrets_masker.py:148: in merge
return _secrets_masker().merge(new_value, old_value, name, max_depth)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
src/airflow_shared/secrets_masker/secrets_masker.py:498: in merge
return self._merge(
src/airflow_shared/secrets_masker/secrets_masker.py:411: in _merge
merged[key] = self._merge(
src/airflow_shared/secrets_masker/secrets_masker.py:403: in _merge
is_sensitive = force_sensitive or (name is not None and
should_hide_value_for_key(name))
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
src/airflow_shared/secrets_masker/secrets_masker.py:95: in
should_hide_value_for_key
from airflow import settings
../../airflow-core/src/airflow/__init__.py:62: in <module>
from airflow import configuration, settings
../../airflow-core/src/airflow/configuration.py:2271: in <module>
secrets_backend_list = initialize_secrets_backends()
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
../../airflow-core/src/airflow/configuration.py:2219: in
initialize_secrets_backends
secrets_backend_cls = import_string(class_name)
^^^^^^^^^^^^^^^^^^^^^^^^^
../../airflow-core/src/airflow/utils/module_loading.py:41: in import_string
module = import_module(module_path)
^^^^^^^^^^^^^^^^^^^^^^^^^^
/opt/homebrew/Cellar/python@3.13/3.13.3_1/Frameworks/Python.framework/Versions/3.13/lib/python3.13/importlib/__init__.py:88:
in import_module
return _bootstrap._gcd_import(name[level:], package, level)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
../../airflow-core/src/airflow/secrets/metastore.py:27: in <module>
from airflow.utils.session import NEW_SESSION, provide_session
../../airflow-core/src/airflow/utils/session.py:25: in <module>
from airflow import settings
../../airflow-core/src/airflow/settings.py:39: in <module>
from airflow._shared.timezones.timezone import local_timezone,
parse_timezone, utc
../../airflow-core/src/airflow/_shared/timezones/timezone.py:24: in <module>
import pendulum
E ModuleNotFoundError: No module named 'pendulum'
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
