jroachgolf84 opened a new issue, #54804:
URL: https://github.com/apache/airflow/issues/54804

   ### Apache Airflow version
   
   main (development)
   
   ### If "Other Airflow 2 version" selected, which one?
   
   _No response_
   
   ### What happened?
   
   I'm working on adding the `PubsubPullTrigger` as a supported `queue` to be 
used by the `MessageQueueTrigger` for event-driven scheduling. However, in the 
code snippet below, a `TriggerEvent` is yielded when an exception occurs in the 
`run` method. This actually triggers a DAG run when used for Asset-driven 
scheduling. In my case, the exception was a missing `project_id` when 
instantiating the Trigger. This triggered DAGs runs over and over until I 
provided a `project_id`.
   
   
https://github.com/apache/airflow/blob/819db98a49886ab695c26818ba9370a96a9c2357/providers/google/src/airflow/providers/google/cloud/triggers/pubsub.py#L88-L108
   
   When a `TriggerEvent` is not yielded, the Triggerer throws an exception that 
says something along the lines of "TriggerEvent was not returned".
   
   Not really a bug, more of a question around weird behavior.
   
   ### What you think should happen instead?
   
   When a child of the `BaseEventTrigger` class returns a `TriggerEvent` with 
`"status": "run"`, an `AssetEvent` should not be created.
   
   ### How to reproduce
   
   Please see the existing PR for details around the changes that are needed to 
reproduce this. 
   
   https://github.com/apache/airflow/pull/54684
   
   ### Operating System
   
   MacOS
   
   ### Versions of Apache Airflow Providers
   
   _No response_
   
   ### Deployment
   
   Other
   
   ### Deployment details
   
   _No response_
   
   ### Anything else?
   
   _No response_
   
   ### Are you willing to submit PR?
   
   - [x] Yes I am willing to submit a PR!
   
   ### Code of Conduct
   
   - [x] I agree to follow this project's [Code of 
Conduct](https://github.com/apache/airflow/blob/main/CODE_OF_CONDUCT.md)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to