Lee-W commented on PR #54783:
URL: https://github.com/apache/airflow/pull/54783#issuecomment-3217972249

   > @guan404ming / @Lee-W thanks for the discussion! My concerns are fixed by 
the rework and looks very good for me!
   > 
   > > I probably need to check whether , exists in each option from the 
backend?
   > 
   > That is really a limitation... that would be a + for having JSON 
support... mhm. I'd think it would be OK to assume no `,` is within the options 
and if somebody complaints then it can be addressed also in future. Would be 
really a nice case in my view.
   > 
   > One option as resolution could be to offer to support JSON as well as 
plain text style... but might be un-needed complexity if nobody is 
using/needing it. Would make it easy for users to consume and still would leave 
the option for the nice cases... I would defer this to a future if really 
somebody needs it.
   
   Thanks for jumping in on the discussion and helping us improve this feature! 
🙌
   
   I totally agree that restricting `_options` and excluding `,` makes sense. 
If anyone really needs these, we can open a new discussion about whether we 
want to go for it and how to make it happen.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to