guan404ming commented on PR #54783:
URL: https://github.com/apache/airflow/pull/54783#issuecomment-3228540196
> I think a simple encodeURIComponent(JSON.stringify(options)) is the
simplest option and leaves less risk to use parsing it wrong. URL readability
isn't a big concern here. And when filling out the form, we simply ignore any
option which doesn't fit a dropdown.
Agree with making it simple, I think it would be easy for user to prepare it
after we got the utility function to generate url with preload options.
Thus currently the url with preloaded data would be
```
...?_options=["option 1", "option 2"]&key=value
```
> We should probably have a "Submit" button on more forms. The number of
clicks is less important than it being clear what you're about to do. I agree
that "Approve" should probably get the default main button styling.
Nice catch, I like this perspective to keep the safety on the first place.
I've update the render logic like:
- show option button with preloaded option highlighted in Approval case
(preloaded with "option 4" and "option 5")
<img width="1920" height="1182" alt="image"
src="https://github.com/user-attachments/assets/ce589f2d-7d34-4fea-a30f-65a6a0b824d9";
/>
- show option dropdown and respond button in the other cases (preloaded with
"Approve")
<img width="1920" height="1200" alt="image"
src="https://github.com/user-attachments/assets/acd180e2-acfd-4b16-a8a6-f1668ec0d6ac";
/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
