sjyangkevin commented on code in PR #54807: URL: https://github.com/apache/airflow/pull/54807#discussion_r2309139743
########## providers/openlineage/tests/system/openlineage/operator.py: ########## Review Comment: I am not an expert to OL operator, but I would suggest include the following information would help people understand more about the issues and the direction for the fix. 1. The test environment and the test command you've run that produce the issue. It will be useful to understand the test environment and to reproduce the issue 2. just want to clarify on "variable" here, if it refers to Airflow Variables 3. what type of error this test return. In generally, the following trade-offs are worth to consider when using `time.sleep`. * It’s not configurable by users or tests. * It consumes worker time unnecessarily (especially worse than deferring). * It’s flaky in tests (adds wall-clock time and race potential). thanks, -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
