dada-engineer commented on code in PR #53884:
URL: https://github.com/apache/airflow/pull/53884#discussion_r2309159338
##########
airflow-core/src/airflow/configuration.py:
##########
@@ -808,6 +809,19 @@ def _upgrade_postgres_metastore_conn(self):
old_env_var = self._env_var_name("core", key)
os.environ.pop(old_env_var, None)
+ def _strip_trailing_slash_from_base_url(self):
Review Comment:
Yes, this is why I created this originally. So I checked several places and
the only reference checking if it ends with / was in the api_server. So all the
other places, like the property [log_url of taskinstance
model](https://github.com/apache/airflow/blob/main/airflow-core/src/airflow/models/taskinstance.py#L623),
just assume the base url is without a trailing slash. My reasoning then was ok
lets just make this assumption hold true and not have this ugly `if not
base_url.endswith("/")` check all over the places.
Edit: I am also fine with just closing this PR and using the other one, I
just see this as source for error again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
