guan404ming commented on code in PR #51564:
URL: https://github.com/apache/airflow/pull/51564#discussion_r2310023033
##########
airflow-core/src/airflow/ui/src/pages/TaskInstances/TaskInstances.tsx:
##########
@@ -51,17 +60,55 @@ const {
STATE: STATE_PARAM,
}: SearchParamsKeysType = SearchParamsKeys;
-const taskInstanceColumns = ({
+const getColumns = ({
+ allRowsSelected,
dagId,
+ onRowSelect,
+ onSelectAll,
runId,
+ selectedRows,
taskId,
translate,
}: {
dagId?: string;
runId?: string;
taskId?: string;
translate: TFunction;
-}): Array<ColumnDef<TaskInstanceResponse>> => [
+} & GetColumnsParams): Array<ColumnDef<TaskInstanceResponse>> => [
+ ...(Boolean(dagId)
Review Comment:
> I feel like people would want to perform bulk actions on the main task
instance list page too?
You're right. I initially disable it since cross dag deletion is not
literally supported by our backend and need a great refactor for bulk service.
But I think we could handle it in our hook now and refactor our backend after
then. I've updated!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
