shahar1 commented on code in PR #55154:
URL: https://github.com/apache/airflow/pull/55154#discussion_r2314449971
##########
dev/i18n/check_translations_completeness.py:
##########
@@ -124,12 +124,7 @@ def expand_plural_keys(keys: set[str], lang: str) ->
set[str]:
def get_locale_files() -> list[LocaleFiles]:
return [
LocaleFiles(
- locale=locale_dir.name,
- files=[
- f.name
- for f in locale_dir.iterdir()
- if f.suffix == ".json" and f.name != "_freeze_exemptions.json"
- ],
Review Comment:
If you merge any changes to the default language during the freeze time with
the label (for whatever reason it is), you modify the bar which we try to
fixate during the freeze, and the calculation of the coverage changes.
I'd like to avoid situations in which translation owners suddenly figure out
that they need to translate 50 more terms that they should have, only because
new features were merged during the freeze.
Using a "buffer file" like I suggested is one methodto solve it - if we only
work with a label, we should define in what circumstances they could be used.
\* Disclaimer: It might be a non-issue for the upcoming release and I just
overengineer the solution, but when there are more languages (hopefully!) - I
could see how it becomes problematic :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
